Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atf: add patch to fix build without bc(1) #92

Open
wants to merge 1 commit into
base: develop-ls-5.15.71-2.2.0
Choose a base branch
from
Open

atf: add patch to fix build without bc(1) #92

wants to merge 1 commit into from

Conversation

sideeffect42
Copy link

This patch fixes mysterious invalid suffix "x" on integer constant errors on build systems without the bc(1) command installed:

plat/nxp/common/setup/ls_bl2_el3_setup.c: In function ‘ls_bl2_el3_plat_arch_setup’:
<command-line>: error: invalid suffix "x" on integer constant
plat/nxp/common/setup/ls_bl2_el3_setup.c:189:31: note: in expansion of macro ‘BL2_BASE’
  189 |                               BL2_BASE,
      |                               ^~~~~~~~
<command-line>: error: invalid suffix "x" on integer constant
plat/nxp/common/setup/ls_bl2_el3_setup.c:190:63: note: in expansion of macro ‘BL2_BASE’
  190 |                               (unsigned long)(&__BL2_END__) - BL2_BASE,
      |                                                               ^~~~~~~~
make: *** [Makefile:1239: /usr/src/lx2160a_build/build/atf/build/lx2160acex7/release/bl2/ls_bl2_el3_setup.o] Error 1

The potential issues, should addresses grow larger than 2 GiB, remain unchanged, because the usage of bc(1) provided no advantages here as the addresses were always calculated in arithmetic expansions for which POSIX.1-2024 only requires a signed long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sideeffect42